-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return booleans indicating whether assertions passed #2696
Return booleans indicating whether assertions passed #2696
Conversation
4eeca1b
to
555e500
Compare
@novemberborn Getting an error like this:
when trying to lint the files or check types ( |
I don't see that XO error output in CI, maybe it's a case of outdated dependencies installed on your machine? There are a lot of other linting errors though. There should be some easier to solve TypeScript errors, like |
555e500
to
9e85479
Compare
@novemberborn thanks for getting back to me. Weird... I have no diff with any packages, and no diff with any configuration files for |
Nice. The solution was quite weird: I commented this out, then ran |
d5cf4bf
to
68db1e6
Compare
Normally throws() returns the error when it passes. Let's not change that.
The previous commit fixed the return-value assertions, catching this one.
@jmarkham828 I've pushed some tweaks, notably in the tests to assert on the return values. The throws assertions shouldn't return booleans which I've also fixed. Would you mind updating the documentation for the assertions that now return booleans? |
Thank you so much for the help, @novemberborn. 🙏 Separately, how could 64ad93e have caused the build to fail 🤔 |
Just flakiness. A different run failed this time. |
Apologies for dropping this. I just finished university! 🥳
Hoping to still contribute to this awesome project. I picked up where this left off. I totally understand if this PR is closed, given that I left it hanging for a while, but wanted to give it another go at resolving #2455, since it doesn't look like #2586 is active any longer.